fix(server/settings): write settings to a temp file then move #1067
Conversation
…d corruption When writing the settings.json file ensure that the file is fully written by writing it to temporary file before renaming it to the final settings path. This should prevent issues where the config gets lost due to the file being corrupted.
Zariel
force-pushed
the
config-save-move
branch
from
ad90260
to
9452f08
Compare
There was a problem hiding this comment.
LGTM, even if I wouldn't have thought that saving the settings would cause any problems though, because the settings aren't updated very often.
@Fallenbagel wdyt about this?
I've just moved to Jellyseerr from Overseerr and didn't do a find references but Overseerr was saying settings very frequently. Running in K8s with ceph-block storage I would regularly be losing the settings to the point where I started trying to figure out what to do about it. The only things I can think of is the process being killed mid write or something happening where the kernel buffer doesnt get flushed, ive not been able to nail down the exact sequence of events but I thought would prevent users from being left with corrupted settings which ends up requiring a fresh setup. |
When writing the settings.json file ensure that the file is fully written by writing it to temporary file before renaming it to the final settings path. This should prevent issues where the config gets lost due to the file being corrupted.
Description
When running in K8S both Jellyseerr and Overseerr have suffered from losing the config due to pod restarts, this change makes it so that the settings.json is first wirtten to a temporary file then it is renamed to its final name. This should help prevent cases where a partial or unflushed write cause the loss of the whole settings.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed